Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly handle chained exceptions in Python 3 #216

Merged
merged 2 commits into from
Jun 6, 2018

Conversation

nicoddemus
Copy link
Member

Fix #215

@coveralls
Copy link

coveralls commented May 30, 2018

Coverage Status

Coverage increased (+0.003%) to 99.252% when pulling 06eda3b on nicoddemus:chained-exceptions into 3bf8af2 on pytest-dev:master.

if sys.version_info.major == 2:
from StringIO import StringIO
else:
from io import StringIO
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not have this import at the top of the file? Might also want to do except ImportError: instead so you don't need sys if you do it at the top.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not have this import at the top of the file?

I put it here locally mostly because this is function is rarely used. If you prefer I can move it to the top though, no problem.

Might also want to do except ImportError: instead so you don't need sys if you do it at the top.

In general I tend to avoid that because it might lead to hard to diagnose errors (see pytest-dev/pytest-mock#68).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@The-Compiler gentle ping. 😁

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair point - seems fine to keep it here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nicoddemus nicoddemus merged commit b923af1 into pytest-dev:master Jun 6, 2018
@nicoddemus nicoddemus deleted the chained-exceptions branch June 6, 2018 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants