Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Correctly handle tracebackhide for chained exceptions (#10772)" #10904

Merged
merged 1 commit into from
Apr 13, 2023

Conversation

bluetech
Copy link
Member

This reverts commit 431ec6d.

Fix #10903.
Reopen #1904.

@bluetech
Copy link
Member Author

cc @Felhof - author of #10722.

Copy link
Member

@RonnyPfannschmidt RonnyPfannschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we give this a little while to see if a simple followup is possible instead of the redo?

@RonnyPfannschmidt
Copy link
Member

nm, i just took note of the analysis in the new bug

@bluetech bluetech merged commit eff54ae into pytest-dev:main Apr 13, 2023
23 checks passed
@bluetech bluetech deleted the revert-10772 branch April 13, 2023 11:52
@nicoddemus
Copy link
Member

nicoddemus commented Apr 13, 2023

Shouldn't we have a new changelog entry stating that this change was reverted?

EDIT: huh, nevermind, don't know how I missed that it is there already. 🤦

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

INTERNALERROR> IndexError: list index out of range in hypothesis and pytest-bdd
3 participants