Fix couple of EncodingWarnings #10954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're not supposed to diverge here, but make this change to fix an unavoidable EncodingWarning that is otherwise raised in pytest's test suite. The behavior should be exactly the same besides the warning, hopefully that won't cause confusion.
for more information, see https://pre-commit.ci
AA-Turner
reviewed
Apr 28, 2023
| @@ -953,7 +953,7 @@ def ensure(self, *args, **kwargs): | |||
| else: | |||
| p.dirpath()._ensuredirs() | |||
| if not p.check(file=1): | |||
| p.open("w").close() | |||
| p.open("wb").close() | |||
There was a problem hiding this comment.
To just touch the file, pathlib uses the below pattern -- this might be a larger change than wanted, though:
Suggested change
| p.open("wb").close() | |
| os.close(os.open(self.strpath, flags=os.O_CREAT)) |
There was a problem hiding this comment.
This code Was strictly copied in to enable drop of the py dep, so let's go for minimal changes instead of nice ones as we want to shed it as soon as possible
RonnyPfannschmidt
approved these changes
Apr 29, 2023
|
Thanks for fixing this! I got the warning in my CI configuration, any idea when a new stable release will be tagged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #10328 (comment) for context.
The
py.pathone might be better to leave as-is, but I lean toward fixing.