faulthandler: avoid accessing sys.stderr.encoding #10979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a pytest-xdist regression after 762bb61 (not yet released). pytest-xdist patches sys.stderr with an object which doesn't have `encoding`. Strictly speaking, this should be fixed there (or more precisely, in execnet), but it will drop support for older versions which don't want. But in any case, the fix turns out to simplify the code, using FD support added in Python 3.5, so it's good anyway! Refs: pytest-dev/pytest-xdist#900
RonnyPfannschmidt
approved these changes
May 10, 2023
|
Thanks @bluetech! |
nicoddemus
approved these changes
May 10, 2023
|
The coverage is 75% because the timeout code is not covered; there is a test for it but it's skipped due to sometimes crashing in CI: pytest/testing/test_faulthandler.py Line 75 in fd56968 |
It's used in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a pytest-xdist regression after 762bb61 (not yet released).
pytest-xdist patches sys.stderr with an object which doesn't have
encoding. Strictly speaking, this should be fixed there (or more precisely, in execnet), but it will drop support for older versions which don't want.But in any case, the fix turns out to simplify the code, using FD support added in Python 3.5, so it's good anyway!
Refs: pytest-dev/pytest-xdist#900