docs changes about limitations with hook function ordering #11635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluetech
requested changes
Nov 27, 2023
| @@ -117,6 +117,10 @@ Hook function ordering / call example | |||
| For any given hook specification there may be more than one | |||
| implementation and we thus generally view ``hook`` execution as a | |||
| ``1:N`` function call where ``N`` is the number of registered functions. | |||
|
|
|||
| There are certain limitations about hooks starting with ``_pytest``. For | |||
There was a problem hiding this comment.
The problematic prefix is pytest_ (not _pytest).
It is not clear which limitations this comment refers to, and the "Declaring new hooks" section doesn't mention any.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to address the issue in #11307.
Approach 2 is taken, where a link to the limitations is added to hook function ordering, so users will be aware of the limitations even when not declaring new hooks. The limitations were previously only in the
Declaring New Hookssection.