New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Full diff issue #11688
Open
JamieC2002
wants to merge
14
commits into
pytest-dev:main
Choose a base branch
from
JamieC2002:full_diff_issue
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Full diff issue #11688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…odifications to the formatting to fix strings that were created with implicit string concatenation.
…into full_diff_issue
…iple multiline strings
for more information, see https://pre-commit.ci
…ated to issue pytest-dev#10863 to account for new changes from main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10863
Resolved issue in Full DIff Output with string lists where strings that were implicitly concatenated/long strings were treated broken up into multiple strings, causing the output format to be misleading. Now, implicitly concatenated strings/long strings are treated as one string, and the output is consistent with other scenarios involving strings.
Test case:
Before:
string in ex is output as two strings.
After:
string in ex is now output as one string.
Worked with @kayliny02.