Adding whitespace escaping on difference display #11696
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #10704.
Resolved issue of terminal output showing unhelpful messages if the differentiating symbols are whitespaces.
Solution in util.py/_diff_text:
We go through the compared strings, checking if any differentiating symbols are both whitespaces,
after which, unless the strings are already fully escaped due being just whitespace, we escape them using
repr() adding explanation why that's happening.
Testing:
Adding new parameter to test_error_diffs which tests the behaviour of displaying whitespaces correctly.
Output of test in the terminal: