delete silly chdir #11844
Open
delete silly chdir #11844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This line causes the below insane behavior. I hypothesize that it's here for no really good reason. https://gist.github.com/bukzor/085b1c2bdaa5bc6033db50d718c48bd3
bukzor
added a commit
to getsentry/tacos-gha
that referenced
this pull request
Jan 18, 2024
it would sometimes raise assertionerror, before background: * https://gist.github.com/bukzor/085b1c2bdaa5bc6033db50d718c48bd3 * pytest-dev/pytest#11844
|
Can you explain what you mean by silly behavior I recall this was added to prevent breakage if pytest was invoked multiple times and the test suite wasn't cleaning up correctly |
|
If you run the test in the gist in the OP, and ctrl-c during its sleep, the
test fails due to a seemingly inexplicable chdir.
I see the failing tests. I made this PR in hope that there was none :).
I'll of course need to find a better solution for those before this could
possibly merge.
…On Fri, Jan 19, 2024, 12:05 AM Ronny Pfannschmidt ***@***.***> wrote:
Can you explain what you mean by silly behavior
I recall this was added to prevent breakage if pytest was invoked multiple
times and the test suite wasn't cleaning up correctly
—
Reply to this email directly, view it on GitHub
<#11844 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAE4KSGSAV3DCRIAHTKDSXTYPIEKFAVCNFSM6AAAAABCBBOXJ6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJZHAZDAMJRGI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
#11826 might have solved this |
bukzor
added a commit
to getsentry/tacos-gha
that referenced
this pull request
Jan 19, 2024
it would sometimes raise assertionerror, before background: * https://gist.github.com/bukzor/085b1c2bdaa5bc6033db50d718c48bd3 * pytest-dev/pytest#11844
github-merge-queue bot
pushed a commit
to getsentry/tacos-gha
that referenced
this pull request
Jan 19, 2024
it would sometimes raise assertionerror, before background: * https://gist.github.com/bukzor/085b1c2bdaa5bc6033db50d718c48bd3 * pytest-dev/pytest#11844
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This line causes the below insane behavior. I hypothesize that it's here for no really good reason.
https://gist.github.com/bukzor/085b1c2bdaa5bc6033db50d718c48bd3
Here is a quick checklist that should be present in PRs.
If this change fixes an issue, please:
closes #XYZWto the PR description and/or commits (whereXYZWis the issue number). See the github docs for more information.Unless your change is trivial or a small documentation fix (e.g., a typo or reword of a small section) please:
Create a new changelog file in the
changelogfolder, with a name like<ISSUE NUMBER>.<TYPE>.rst. See changelog/README.rst for details.Write sentences in the past or present tense, examples:
Add yourself to
AUTHORSin alphabetical order.