Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move show-fixtures code from python.py to fixtures.py #11910

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

bluetech
Copy link
Member

@bluetech bluetech commented Feb 2, 2024

It makes more sense, also, we have a long term idea of generalizing fixture support to items defined by other plugins, not just python, in which case --fixtures would definitely not be python-plugin specific.

@WarrenTheRabbit
Copy link
Contributor

WarrenTheRabbit commented Mar 18, 2024

@bluetech Moving the code to fixtures.py sounds great to me, and your remark about generalising fixture support is very interesting.

I recently tried to resolve an issue with #12129. @The-Compiler floated the idea originally in #11295 and I give three justifications in my PR description (and one comment) for making the change.

But in short, I was working in python.py. Intuitively, I would have preferred to be in fixtures.py, and in fact I had to import a function from there. I was wanting to make a separate proposal to move the code into fixtures.py, or indeed to ask what the rules are around breaking out content from large files into specialised subfiles. e.g. parts of fixtures.py into show_fixtures.py, for instance.

Also, greetings to all. I hope everyone has been well. Hopefully I have now returned and can be more involved; assuming, in (my recollection of) @RonnyPfannschmidt's words, I'm not put through another bad fate compression algorithm.

It makes more sense, also, we have a long term idea of generalizing
fixture support to items defined by other plugins, not just python, in
which case `--fixtures` would definitely not be python-plugin
specific.
@bluetech bluetech merged commit b63bea9 into pytest-dev:main Apr 2, 2024
23 of 24 checks passed
@bluetech bluetech deleted the move-show-fixtures branch April 2, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants