Deprecate pytest namespace #3735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This hook has been deprecated and will be removed in the future. Fix pytest-dev#2639
src/_pytest/hookspec.py
Outdated
| .. warning:: | ||
| This hook has been **deprecated** and will be removed in pytest 4.0. | ||
|
|
||
| Plugins who need this feature are suggested |
There was a problem hiding this comment.
i propose to align this somewhere along
Plugins whose users depend on the current name-space functionality should prepare to migrate to a namespace they actually own.
To support the migration its suggested to trigger `DeprecationWarnings` for objects they put into the pytest namespace.
An stopgap measure to avoid the warning is to monkeypatch the `pytest` module.
but just as the `pytest_namespace` hook this should be seen as a temporary measure to be removed.
simply to avoid accidentally declaring monkeypatching ´pytest` fine
|
the base dance removed the already merged commits, i'm puzzled as to why its not more easy |
Yeah it should detect that automatically. |
src/_pytest/hookspec.py
Outdated
| @hookspec(historic=True) | ||
| @hookspec( | ||
| historic=True, | ||
| warn_on_impl=RemovedInPytest4Warning( |
There was a problem hiding this comment.
i just noticed that we didn't declare this one in the deprecated module, lets please move the actual declaration there
asottile
approved these changes
Jul 30, 2018
This was referenced Oct 9, 2018
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on #3732, so it is better to review after that PR gets merged.
Fix #2639