Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added acceptance tests for 'config warnings' stacklevel #5790

Closed
wants to merge 2 commits into from

Conversation

viveksoundrapandi
Copy link

Fixes bug #4445

@nicoddemus
Copy link
Member

Hi @viveksoundrapandi,

First of all thanks a lot for taking the time to contributing to the project, the team definitely appreciates it! 😁

Unfortunately this is not the correct approach; not your fault at all, unfortunately the thread in #4445 was left hanging and it was not clear to those involved how to proceed.

I just included an explanation in #4445 (comment), hopefully that makes it clear what the issue is about.

I'm closing this now because unfortunately I think this needs to be restarted from scratch, but please don't let this discourage you from trying again, either on this issue or another one from our issue tracker. 👍

@nicoddemus nicoddemus closed this Aug 27, 2019
@viveksoundrapandi
Copy link
Author

Thanks for the details @nicoddemus .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants