terminal: use "yellow" with any "xpassed" tests #6425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blueyed
commented
Jan 9, 2020
| @@ -0,0 +1 @@ | |||
| Use "yellow" main color with any XPASSED tests. | |||
There was a problem hiding this comment.
Suggested change
| Use "yellow" main color with any XPASSED tests. | |
| Use yellow main color with any XPASSED tests. |
bluetech
reviewed
Jan 15, 2020
| @@ -0,0 +1 @@ | |||
| Use "yellow" main color with any XPASSED tests. | |||
There was a problem hiding this comment.
IIUC there is no actual change here, because the previous code (probably unintentionally) used the fallback color, which is also yellow. So the changelog can be dropped as it might be confusing.
There was a problem hiding this comment.
..only if there is no passed one.
So now it is yellow always with an xpass.
There was a problem hiding this comment.
Oh right, I missed that this talks about the main color.
blueyed
added a commit
to blueyed/pytest
that referenced
this pull request
Jan 21, 2020
(cherry picked from commit 13baab7) Ref: pytest-dev#6425 Ref: pytest-dev#449.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #449.