[Backport 5.4] Merge pull request #6991 from blueyed/fix-lf-cmdline-args-upstream #7219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluetech
reviewed
May 27, 2020
| @@ -0,0 +1 @@ | |||
| Collected files are displayed after any reports from hooks, e.g. the status from ``--lf``. | |||
There was a problem hiding this comment.
Maybe we should drop this change from the backport? (the changes in src/_pytest/terminal.py)
| x | ||
| for x in result | ||
| if x.nodeid in lastfailed | ||
| # Include any passed arguments (not trivial to filter). |
| if x.nodeid in lastfailed | ||
| # Include any passed arguments (not trivial to filter). | ||
| or session.isinitpath(x.fspath) | ||
| # Keep all sub-collectors. |
There was a problem hiding this comment.
But I don't really understand this one, would you mind explaining what it does?
| def pytest_collection_modifyitems( | ||
| self, config: Config, items: List[nodes.Item] | ||
| ) -> Generator[None, None, None]: | ||
| yield |
There was a problem hiding this comment.
Why is this change (and in pytest_collection_modifyitems) needed?
There was a problem hiding this comment.
i believe this is to ensure the actual code runs as late as possible
in this case this means, its running after most normal hook-wrappers finish (only the last bit of a earlier hook-wrapper could interact with it after that
|
Closing for now, not sure we will see a 5.4.X before 6.0 anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #6991
But I'm not so sure we should backport this, because it also contains an improvement (albeit small).