Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

logging: some simplifications/cleanups #7224

Merged
merged 12 commits into from
May 17, 2020
Merged

logging: some simplifications/cleanups #7224

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
ac6c02f
logging: use item's store for private attributes
bluetech May 17, 2020
9effbe7
logging: inline _runtest_for_main into _runtest_for
bluetech May 17, 2020
ce0f218
logging: yield from _runtest_for instead of contextmanager
bluetech May 17, 2020
eceb28e
logging: set formatter on handler creation, not in catching_logs
bluetech May 17, 2020
e48ac69
logging: optimize catching_logs slightly
bluetech May 17, 2020
075903d
logging: simplify log-file handling
bluetech May 17, 2020
b13af52
logging: call set_when() in a consistent manner
bluetech May 17, 2020
bd657ba
logging: don't use _runtest_for for the pytest_log* hooks
bluetech May 17, 2020
43c465c
logging: use dummy handler when CLI logging is disabled instead of None
bluetech May 17, 2020
bd5e3f0
logging: move log_file_handler cleanup from sessionend to unconfigure
bluetech May 17, 2020
3f82006
logging: remove deprecated --no-print-logs option/ini
bluetech May 17, 2020
f71ec8c
logging: order hookimpl's in chronological order
bluetech May 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions changelog/7224.breaking.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
The `item.catch_log_handler` and `item.catch_log_handlers` attributes, set by the
logging plugin and never meant to be public , are no longer available.

The deprecated ``--no-print-logs`` option is removed. Use ``--show-capture`` instead.
4 changes: 2 additions & 2 deletions doc/en/deprecations.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,10 +37,10 @@ a public API and may break in the future.
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

.. deprecated:: 5.4
.. versionremoved:: 6.0


Option ``--no-print-logs`` is deprecated and meant to be removed in a future release. If you use ``--no-print-logs``, please try out ``--show-capture`` and
provide feedback.
Option ``--no-print-logs`` is removed. If you used ``--no-print-logs``, please use ``--show-capture`` instead.

``--show-capture`` command-line option was added in ``pytest 3.5.0`` and allows to specify how to
display captured output when tests fail: ``no``, ``stdout``, ``stderr``, ``log`` or ``all`` (the default).
Expand Down
5 changes: 0 additions & 5 deletions src/_pytest/deprecated.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,11 +54,6 @@
"for more information."
)

NO_PRINT_LOGS = PytestDeprecationWarning(
"--no-print-logs is deprecated and scheduled for removal in pytest 6.0.\n"
"Please use --show-capture instead."
)

COLLECT_DIRECTORY_HOOK = PytestDeprecationWarning(
"The pytest_collect_directory hook is not working.\n"
"Please use collect_ignore in conftests or pytest_collection_modifyitems."
Expand Down