Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

7291: Replace py.iniconfig with iniconfig #7292

Merged
merged 2 commits into from
Jun 3, 2020
Merged

7291: Replace py.iniconfig with iniconfig #7292

merged 2 commits into from
Jun 3, 2020

Conversation

kerizane
Copy link
Contributor

@kerizane kerizane commented Jun 1, 2020 •
edited by nicoddemus

Fix #7291

@nicoddemus
Copy link
Member

Thanks @kerizane!

Weird, not sure why CI is failing, we no longer require wcwidth at all... cc @bluetech

RonnyPfannschmidt
RonnyPfannschmidt approved these changes Jun 2, 2020
View reviewed changes
Copy link
Member

@RonnyPfannschmidt RonnyPfannschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking up that one

@bluetech
Copy link
Member

bluetech commented Jun 2, 2020

Weird, not sure why CI is failing, we no longer require wcwidth at all... cc @bluetech

I re-ran the CI and it seems fine now, not sure why it tried to fetch wcwidth before.

@nicoddemus nicoddemus mentioned this pull request Jun 2, 2020
Closed
@nicoddemus nicoddemus merged commit cf640a9 into pytest-dev:master Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RonnyPfannschmidt RonnyPfannschmidt RonnyPfannschmidt approved these changes

@nicoddemus nicoddemus nicoddemus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

switch from py.iniconfig to iniconfig
4 participants
@kerizane @nicoddemus @bluetech @RonnyPfannschmidt