Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add details to error message for junit #7390

Merged
merged 3 commits into from
Jun 23, 2020
Merged

Add details to error message for junit #7390

merged 3 commits into from
Jun 23, 2020

Conversation

dajose
Copy link
Contributor

@dajose dajose commented Jun 19, 2020

closes #7385

nicoddemus
nicoddemus approved these changes Jun 20, 2020
View reviewed changes
Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dajose, looks good to me!

Could you also add yourself to AUTHORS?

@nicoddemus
Copy link
Member

(We should squash-merge this)

@dajose
Copy link
Contributor Author

dajose commented Jun 20, 2020

thanks @nicoddemus :) :)

I'm already on the authors 🤓

@nicoddemus
Copy link
Member

I'm already on the authors

Oh sorry, great then! 😁

@dajose
Copy link
Contributor Author

dajose commented Jun 22, 2020

@nicoddemus excuse me being intense... but are we waiting for more reviewers? or maybe something on my side?

@nicoddemus
Copy link
Member

excuse me being intense

Not at all, don't worry about pinging!

but are we waiting for more reviewers? or maybe something on my side?

The former. We usually wait a bit to see if other maintainers want to take a second look.

I will merge this tomorrow unless someone else wants more time to review this. 👍

@nicoddemus nicoddemus merged commit 617bf8b into pytest-dev:master Jun 23, 2020
@nicoddemus
Copy link
Member

Thanks @dajose!

@dajose
Copy link
Contributor Author

dajose commented Jun 23, 2020

thanks to you @nicoddemus :)

Vlad-Radz pushed a commit to Vlad-Radz/pytest that referenced this pull request Jun 24, 2020
@dajose @nicoddemus @vlad-nc
Add details to error message for junit (pytest-dev#7390)
703f2ce 
Co-authored-by: Bruno Oliveira <nicoddemus@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicoddemus nicoddemus nicoddemus approved these changes

@bluetech bluetech bluetech approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

junit error message is not very descriptive
3 participants
@dajose @nicoddemus @bluetech