Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#9062 - Allow --stepwise-skip to implicitly enable --stepwise #9064

Merged
merged 2 commits into from Aug 30, 2021

Conversation

symonk
Copy link
Member

@symonk symonk commented Aug 30, 2021

The StepwisePlugin plugin instance was only registered with pluggy when --stepwise was explicitly provided, this could be confusing where users would / could pass --stepwise-skip in isolation and observe no expected behaviour.

  • --stepwise-skip can now work alone, implicitly enabling --stepwise

closes #9062

Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

changelog/9062.improvement.rst Outdated Show resolved Hide resolved
Co-authored-by: Bruno Oliveira <nicoddemus@gmail.com>
@nicoddemus
Copy link
Member

(Just a note to squash this before merging)

@symonk symonk merged commit 740abd9 into pytest-dev:main Aug 30, 2021
@symonk symonk deleted the 9062-allow-stepwise-skip-in-isolation branch August 30, 2021 18:24
@symonk
Copy link
Member Author

symonk commented Aug 30, 2021

(Just a note to squash this before merging)

just saw this popup while clicking merge in the same millisecond, github is so smooth! I always make sure to squash now 👍

@nicoddemus
Copy link
Member

Hehehe no big deal, thanks again for the PR! 👍

RonnyPfannschmidt pushed a commit to RonnyPfannschmidt/pytest that referenced this pull request Oct 1, 2021
…pwise` (pytest-dev#9064)

* pytest-dev#9062 - Allow `--stepwise-skip` to implicitly enable `--stepwise`

* Update changelog/9062.improvement.rst

Co-authored-by: Bruno Oliveira <nicoddemus@gmail.com>

Co-authored-by: Bruno Oliveira <nicoddemus@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--stepwise-skip has no effect without --stepwise
2 participants