minor tweaks for terminal.py #9243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluetech
reviewed
Oct 30, 2021
bluetech
reviewed
Nov 2, 2021
|
Thanks @bluetech between some reverts & the other PR outlined this ended up being tiny, sorry to take your time for such trivial changes in the end. Appreciate it as always (will make sure to squash if you feel the list comp change is worth while!) |
bluetech
approved these changes
Nov 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some minor tweaks to the
terminal.pymodule, namely:mywriterand_locationline(tags and lineno respectively), neither appear usedgetreportsto use a list comp_getfailureheadlineedit: Other merged PRs have done some of the same work here, so its quite miniscule now