New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
9202 Update codecov uploader #9252
9202 Update codecov uploader #9252
Conversation
8483393
to
643c525
Compare
c81532d
to
0b4b7ad
Compare
for more information, see https://pre-commit.ci
…thub.com/cristianMeli/pytest into enhancement/9202-update-codecov-uploader
This PR absolutely needs a squash and merge 😅. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to work, thanks @cristianMeli!
Two things:
-
We can remove the
scripts/upload-coverage.sh
file now - can you do it? -
Any particular reason you added the explicit
use_coverage: false
lines? I think they were omitted intentionally so the jobs that are reporting coverage stand out.
Hi @bluetech
|
I think, let's try to remove the explicit |
@bluetech yeah, it works. Thanks! |
Closes #9202