Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

9202 Update codecov uploader #9252

Merged

Conversation

cristianMeli
Copy link
Contributor

  • Include documentation when adding new features.
  • Include new tests or update existing tests when applicable.
  • Allow maintainers to push and squash when merging my commits. Please uncheck this if you prefer to squash the commits yourself.

Closes #9202

@cristianMeli cristianMeli force-pushed the enhancement/9202-update-codecov-uploader branch from 8483393 to 643c525 Compare October 30, 2021 22:50
@cristianMeli cristianMeli force-pushed the enhancement/9202-update-codecov-uploader branch from c81532d to 0b4b7ad Compare October 30, 2021 23:04
@cristianMeli
Copy link
Contributor Author

This PR absolutely needs a squash and merge 😅.

Copy link
Member

@bluetech bluetech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to work, thanks @cristianMeli!

Two things:

  • We can remove the scripts/upload-coverage.sh file now - can you do it?

  • Any particular reason you added the explicit use_coverage: false lines? I think they were omitted intentionally so the jobs that are reporting coverage stand out.

@cristianMeli
Copy link
Contributor Author

cristianMeli commented Nov 1, 2021

Hi @bluetech

  • Yes I can remove it.

  • First I added because I had coverage errors in some steps, but maybe it was that the if was wrong. Besides that, I think that is better to explicitly set use_coverage: false for those steps that the coverage report is not generated, also in this way all have the same data. What do you think?

@bluetech
Copy link
Member

bluetech commented Nov 1, 2021

What do you think?

I think, let's try to remove the explicit use_coverage: false and see if it works; if not, we can keep them.

@cristianMeli
Copy link
Contributor Author

@bluetech yeah, it works. Thanks!

@bluetech bluetech merged commit f288afd into pytest-dev:main Nov 1, 2021
@cristianMeli cristianMeli deleted the enhancement/9202-update-codecov-uploader branch November 1, 2021 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Codecov bash uploader is deprecated
2 participants