-
-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unpin tox #1093
Conversation
no it doesn't |
Wait, if it works locally but not in GHA, maybe it's the plugin's fault? I think I've seen a corresponding plugin for tox4 being separate from the one for tox3. |
no, I ran |
Ah, I see. But FTR there's https://github.com/tox-dev/tox-gh too. |
What does that to do with anything? Our problem is that the package pins for Mypy are from PyPI instead of from the local package. I don't see how the plugins play into that. |
It's unrelated to the mypy problem but is related to the tox4 migration, IIUC. |
According to https://pypi.org/project/tox-gh-actions/, tox-gh-actions>=3 works with tox 3 just fine. I would switch if there's any upsides, but I can't see any rn? Anyways, tox has fixed the bug 🎉 and we're waiting for a release now. |
Looks like it's |
FWIW here's some notes regarding the differences tox-dev/tox-gh#7 (comment) |
what the flying fuck is going on now… it works perfectly fine on my machine!? |
Looks related to the recent Hatch-scm integration. At least one of the logs failed on |
but but but… it used to work! otherwise i wouldn’t have merged it! :( I’m currently in the process of setting up a new computer, once I’m fully functional I’ll look closer sigh |
FWIW I checked this branch locally and it does work. Maybe somebody needs to stick https://github.com/marketplace/actions/debugging-with-tmate there and inspect the worker over SSH. Oh, and I just remembered the most typical setuptools-scm mistake — the contributors usually have a full Git clone locally but CIs tend to do shallow clones. The fix is usually to set the fetch depth to 0 or run git unshallow. Though, maybe this is not the only problem here, I haven't had time to dig deeper. |
for more information, see https://pre-commit.ci
0c9b54c #genius |
FTR on tox-gh: it seems like it has a very different way of working than tax-gh-actions. I tries using it with structlog and (using screenshot b/c logs get lost over time) |
It works locally for me.