Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addressing problems raised in sphinx_issues #10104 #863

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Commits on Apr 22, 2022

  1. Addressing problems raised in sphinx_issues #10104

    hoangduytranuk committed Apr 22, 2022
    Configuration menu
    Copy the full SHA
    3258580 View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2022

  1. Corrected the unnecesary codes that was introduced in the last fix to…

    … the issue 10104 by simlify in down to checking for list instance of the input and making sure that they are.
    hoangduytranuk committed Apr 24, 2022
    Configuration menu
    Copy the full SHA
    67aa652 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    53c89f4 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    7bddb4b View commit details
    Browse the repository at this point in the history

Commits on May 15, 2022

  1. This fix propose following changes which can be significant to the NO…

    …RMAL behaviour user expected:
    
    1. PYTHON_FORMAT will correctly, with some degrees of limitation (haven't found with sampled test file of Blender UI translation file, but that doesn't mean it will not be broken again) identify '%s' '%d' flags in the messages and flag it as 'python-format', which removed mistaken recognitions of percentage sign, ie. '%50' as a python-format, which POEditor will flag up as an ERROR in the message.
    2. Locations and comments are sorted Alphabetically and removed duplicated redundant lines.
    3. Comment lines are NO LONGER wrapped with provided line_width. There appeared to be an error in the xgettext code when running with --no-wrap flag. Message bodies (ie. msgid, msgstr) should be wrapped but NOT comments. The wrapping can cause unnecessary version changes appeared in the repository submissions.
    hoangduytranuk committed May 15, 2022
    Configuration menu
    Copy the full SHA
    314b648 View commit details
    Browse the repository at this point in the history
  2. This fix propose following changes which can be significant to the NO…

    …RMAL behaviour user expected:
    
    1. PYTHON_FORMAT will correctly, with some degrees of limitation (haven't found with sampled test file of Blender UI translation file, but that doesn't mean it will not be broken again) identify '%s' '%d' flags in the messages and flag it as 'python-format', which removed mistaken recognitions of percentage sign, ie. '%50' as a python-format, which POEditor will flag up as an ERROR in the message.
    2. Locations and comments are sorted Alphabetically and removed duplicated redundant lines.
    3. Comment lines are NO LONGER wrapped with provided line_width. There appeared to be an error in the xgettext code when running with --no-wrap flag. Message bodies (ie. msgid, msgstr) should be wrapped but NOT comments. The wrapping can cause unnecessary version changes appeared in the repository submissions.
    
    Resolved merge conflicts with previous changes
    hoangduytranuk committed May 15, 2022
    Configuration menu
    Copy the full SHA
    90dd90d View commit details
    Browse the repository at this point in the history