chore: reduce usage of 'from mod_foo import class_foo' #2872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnVillalovos
force-pushed
the
jlvillal/reduce_from_imports
branch
from
6a1be5d
to
bcebcf7
Compare
JohnVillalovos
changed the title
nejch
reviewed
May 17, 2024
There was a problem hiding this comment.
Thanks @JohnVillalovos I guess it makes sense to align as we have a huge mix now in the library.
But I think this PR doesn't really replace class/function imports, it replaces from-imports with plain imports. Which I think is not the idea behind Google's styleguide that I think this is trying to follow. See https://google.github.io/styleguide/pyguide.html#22-imports. I think their idea would be from requests import auth -> auth.AuthBase.
I'm not sure the full path is always needed when referencing especially with modern IDEs and code intelligence enabled on GitHub/GitLab?
JohnVillalovos
force-pushed
the
jlvillal/reduce_from_imports
branch
from
bcebcf7
to
d0e54a1
Compare
Reduce usage of doing: from SOME_MODULE import SOME_CLASS_OR_FUNCTION Instead use: import SOME_MODULE And then use the full module name. This improves readability and makes obvious to the reader where the class or function has come from.
JohnVillalovos
force-pushed
the
jlvillal/reduce_from_imports
branch
from
d0e54a1
to
a2302d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce usage of doing:
from SOME_MODULE import SOME_CLASS_OR_FUNCTION
Instead use:
import SOME_MODULE
And then use the full module name. This improves readability and makes obvious to the reader where the class or function has come from.