Allow validation of Cloud Build json configs
#427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sirosen
approved these changes
May 5, 2024
|
Awesome. @ me if I can ever help with upstream Cloud Build issues filed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Google Cloud Build config validation is originally how I found this repo. At SchemaStore the schema had been neglected for a while so I updated it there.
Most Cloud Build configs use
yaml, and it's possible at the time thecheck-cloudbuildhook was added here that was the only option. However, Cloud Build does allowjsonconfigs. I've updated the catalogue to reflect this and re-generated the hook.Never noticed this since all my configs are
yaml, but this should help others out. 馃殌