Skip to content

Commit

Permalink
Merge pull request #6178 from radarhere/imagetk
Browse files Browse the repository at this point in the history
Deprecated PhotoImage.paste() box parameter
  • Loading branch information
hugovk committed Apr 3, 2022
2 parents 19c8a64 + 2f88192 commit 188211a
Show file tree
Hide file tree
Showing 3 changed files with 22 additions and 3 deletions.
7 changes: 7 additions & 0 deletions Tests/test_imagetk.py
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,13 @@ def test_photoimage_blank():
assert_image_equal(reloaded.convert(mode), im)


def test_box_deprecation():
im = hopper()
im_tk = ImageTk.PhotoImage(im)
with pytest.warns(DeprecationWarning):
im_tk.paste(im, (0, 0, 128, 128))


def test_bitmapimage():
im = hopper("1")

Expand Down
7 changes: 7 additions & 0 deletions docs/deprecations.rst
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,13 @@ The stub image plugin ``FitsStubImagePlugin`` has been deprecated and will be re
Pillow 10.0.0 (2023-07-01). FITS images can be read without a handler through
:mod:`~PIL.FitsImagePlugin` instead.

PhotoImage.paste box parameter
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

.. deprecated:: 9.2.0

The ``box`` parameter is unused. It will be removed in Pillow 10.0.0 (2023-07-01).

Removed features
----------------

Expand Down
11 changes: 8 additions & 3 deletions src/PIL/ImageTk.py
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
#

import tkinter
import warnings
from io import BytesIO

from . import Image
Expand Down Expand Up @@ -183,11 +184,15 @@ def paste(self, im, box=None):
:param im: A PIL image. The size must match the target region. If the
mode does not match, the image is converted to the mode of
the bitmap image.
:param box: A 4-tuple defining the left, upper, right, and lower pixel
coordinate. See :ref:`coordinate-system`. If None is given
instead of a tuple, all of the image is assumed.
"""

if box is not None:
warnings.warn(
"The box parameter is deprecated and will be removed in Pillow 10 "
"(2023-07-01).",
DeprecationWarning,
)

# convert to blittable
im.load()
image = im.im
Expand Down

0 comments on commit 188211a

Please sign in to comment.