Do not attempt normalization if image is already normal

python-pillow · Oct 6, 2022 · b8cd3e7 · b8cd3e7
1 parent 243402e
commit b8cd3e7
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/Tests/test_image_convert.py b/Tests/test_image_convert.py
@@ -38,6 +38,12 @@ def convert(im, mode):
             convert(im, output_mode)
 
 
+def test_unsupported_conversion():
+    im = hopper()
+    with pytest.raises(ValueError):
+        im.convert("INVALID")
+
+
 def test_default():
 
     im = hopper("P")

diff --git a/src/PIL/Image.py b/src/PIL/Image.py
@@ -1036,7 +1036,10 @@ def convert_transparency(m, v):
         except ValueError:
             try:
                 # normalize source image and try again
-                im = self.im.convert(getmodebase(self.mode))
+                modebase = getmodebase(self.mode)
+                if modebase == self.mode:
+                    raise
+                im = self.im.convert(modebase)
                 im = im.convert(mode, dither)
             except KeyError as e:
                 raise ValueError("illegal conversion") from e