switch to #z for comment parameter

* means `comment=None` can be passed directly * no need to conditionally run `str.encode()` * clean up checking of whether a comment is passed
python-pillow · Dec 5, 2022 · eddc9bd · eddc9bd
1 parent 399975f
commit eddc9bd
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 5 deletions.
diff --git a/src/PIL/JpegImagePlugin.py b/src/PIL/JpegImagePlugin.py
@@ -736,9 +736,7 @@ def validate_qtables(qtables):
             )
             i += 1
 
-    comment = info.get("comment", im.info.get("comment")) or b""
-    if isinstance(comment, str):
-        comment = comment.encode()
+    comment = info.get("comment", im.info.get("comment"))
 
     # "progressive" is the official name, but older documentation
     # says "progression"

diff --git a/src/encode.c b/src/encode.c
@@ -1057,7 +1057,7 @@ PyImaging_JpegEncoderNew(PyObject *self, PyObject *args) {
 
     if (!PyArg_ParseTuple(
             args,
-            "ss|nnnnnnnnOy#y#y#",
+            "ss|nnnnnnnnOz#y#y#",
             &mode,
             &rawmode,
             &quality,

diff --git a/src/libImaging/JpegEncode.c b/src/libImaging/JpegEncode.c
@@ -278,7 +278,7 @@ ImagingJpegEncode(Imaging im, ImagingCodecState state, UINT8 *buf, int bytes) {
 
         case 4:
 
-            if (context->comment_size > 0) {
+            if (context->comment) {
                 jpeg_write_marker(&context->cinfo, JPEG_COM, (unsigned char *)context->comment, context->comment_size);
             }
             state->state++;