Exif writing fixes: Rational boundaries and signed/unsigned types #3980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
radarhere
force-pushed
the
exif-writing-fixes
branch
from
ed2913c
to
524933a
Compare
Merged
kkopachev
changed the title
|
I am totally dropping the ball at this one. This seems to fix #4037. I didn't add very specific test case for it; it's kind of covered by same condition for RATIONAL/STRATIONAL tests. Let me know if I should add a specific test. |
Corrected short and long range checks
# Conflicts: # Tests/test_file_tiff_metadata.py
|
Let me know, if you prefer this rebased/squashed. |
radarhere
reviewed
Sep 7, 2019
| original[k] = tuple( | ||
| IFDRational(*_limit_rational(elt, 2 ** 31)) for elt in v | ||
| ) | ||
|
|
There was a problem hiding this comment.
Why remove this part of the test?
There was a problem hiding this comment.
It seems disfunctional and wrong.
The fact that Pillow used to incorrectly limit unsigned rationals to 2**31, does not need to be validated. TIFF allows for rationals to be up to 2**32. If original file contained bigger (but still valid) value, then it has to be the same when Pillow saves it.
radarhere
force-pushed
the
exif-writing-fixes
branch
from
d0c78ef
to
8924054
Compare
d-fence
added a commit
to odoo-dev/odoo
that referenced
this pull request
Feb 5, 2021
On odoo.sh, in some circumstances, when uploading an image as attachment in odoo leads to a blank image thumbnail. The same image was successfully uploaded in the same odoo version on runbot instance. After some investigations, it appears that the issue comes from the python-pillow version used. A few bugs exists [0,1,2] in python-pillow 7.0.0 (packaged in ubuntu Focal) that are now fixed in version 8.1.0 [3,4,5] (packaged in Debian and specified in Odoo requirements.txt), that causes the `ImageOps.exif_transpose` method to fail. The present issue can be considered as a corner case as only images with particular exif tags cause the issue. The present fix is a simple workaround by first checking the presence of the orientation tag and using it, we can avoid a call to the `exif_transpose` method. opw-2369166 [0] python-pillow/Pillow#4346 [1] python-pillow/Pillow#3973 [2] python-pillow/Pillow#4238 [3] python-pillow/Pillow#4637 [4] python-pillow/Pillow#3980 [5] python-pillow/Pillow#4009
robodoo
pushed a commit
to odoo/odoo
that referenced
this pull request
Feb 5, 2021
On odoo.sh, in some circumstances, when uploading an image as attachment in odoo leads to a blank image thumbnail. The same image was successfully uploaded in the same odoo version on runbot instance. After some investigations, it appears that the issue comes from the python-pillow version used. A few bugs exists [0,1,2] in python-pillow 7.0.0 (packaged in ubuntu Focal) that are now fixed in version 8.1.0 [3,4,5] (packaged in Debian and specified in Odoo requirements.txt), that causes the `ImageOps.exif_transpose` method to fail. The present issue can be considered as a corner case as only images with particular exif tags cause the issue. The present fix is a simple workaround by first checking the presence of the orientation tag and using it, we can avoid a call to the `exif_transpose` method. opw-2369166 [0] python-pillow/Pillow#4346 [1] python-pillow/Pillow#3973 [2] python-pillow/Pillow#4238 [3] python-pillow/Pillow#4637 [4] python-pillow/Pillow#3980 [5] python-pillow/Pillow#4009 closes #65584 Signed-off-by: Christophe Monniez (moc) <moc@odoo.com>
fw-bot
pushed a commit
to odoo-dev/odoo
that referenced
this pull request
Feb 5, 2021
On odoo.sh, in some circumstances, when uploading an image as attachment in odoo leads to a blank image thumbnail. The same image was successfully uploaded in the same odoo version on runbot instance. After some investigations, it appears that the issue comes from the python-pillow version used. A few bugs exists [0,1,2] in python-pillow 7.0.0 (packaged in ubuntu Focal) that are now fixed in version 8.1.0 [3,4,5] (packaged in Debian and specified in Odoo requirements.txt), that causes the `ImageOps.exif_transpose` method to fail. The present issue can be considered as a corner case as only images with particular exif tags cause the issue. The present fix is a simple workaround by first checking the presence of the orientation tag and using it, we can avoid a call to the `exif_transpose` method. opw-2369166 [0] python-pillow/Pillow#4346 [1] python-pillow/Pillow#3973 [2] python-pillow/Pillow#4238 [3] python-pillow/Pillow#4637 [4] python-pillow/Pillow#3980 [5] python-pillow/Pillow#4009 X-original-commit: b83c48d
fw-bot
pushed a commit
to odoo-dev/odoo
that referenced
this pull request
Feb 5, 2021
On odoo.sh, in some circumstances, when uploading an image as attachment in odoo leads to a blank image thumbnail. The same image was successfully uploaded in the same odoo version on runbot instance. After some investigations, it appears that the issue comes from the python-pillow version used. A few bugs exists [0,1,2] in python-pillow 7.0.0 (packaged in ubuntu Focal) that are now fixed in version 8.1.0 [3,4,5] (packaged in Debian and specified in Odoo requirements.txt), that causes the `ImageOps.exif_transpose` method to fail. The present issue can be considered as a corner case as only images with particular exif tags cause the issue. The present fix is a simple workaround by first checking the presence of the orientation tag and using it, we can avoid a call to the `exif_transpose` method. opw-2369166 [0] python-pillow/Pillow#4346 [1] python-pillow/Pillow#3973 [2] python-pillow/Pillow#4238 [3] python-pillow/Pillow#4637 [4] python-pillow/Pillow#3980 [5] python-pillow/Pillow#4009 X-original-commit: b83c48d
fw-bot
pushed a commit
to odoo-dev/odoo
that referenced
this pull request
Feb 5, 2021
On odoo.sh, in some circumstances, when uploading an image as attachment in odoo leads to a blank image thumbnail. The same image was successfully uploaded in the same odoo version on runbot instance. After some investigations, it appears that the issue comes from the python-pillow version used. A few bugs exists [0,1,2] in python-pillow 7.0.0 (packaged in ubuntu Focal) that are now fixed in version 8.1.0 [3,4,5] (packaged in Debian and specified in Odoo requirements.txt), that causes the `ImageOps.exif_transpose` method to fail. The present issue can be considered as a corner case as only images with particular exif tags cause the issue. The present fix is a simple workaround by first checking the presence of the orientation tag and using it, we can avoid a call to the `exif_transpose` method. opw-2369166 [0] python-pillow/Pillow#4346 [1] python-pillow/Pillow#3973 [2] python-pillow/Pillow#4238 [3] python-pillow/Pillow#4637 [4] python-pillow/Pillow#3980 [5] python-pillow/Pillow#4009 X-original-commit: b83c48d
This was referenced Feb 5, 2021
fw-bot
pushed a commit
to odoo-dev/odoo
that referenced
this pull request
Feb 5, 2021
On odoo.sh, in some circumstances, when uploading an image as attachment in odoo leads to a blank image thumbnail. The same image was successfully uploaded in the same odoo version on runbot instance. After some investigations, it appears that the issue comes from the python-pillow version used. A few bugs exists [0,1,2] in python-pillow 7.0.0 (packaged in ubuntu Focal) that are now fixed in version 8.1.0 [3,4,5] (packaged in Debian and specified in Odoo requirements.txt), that causes the `ImageOps.exif_transpose` method to fail. The present issue can be considered as a corner case as only images with particular exif tags cause the issue. The present fix is a simple workaround by first checking the presence of the orientation tag and using it, we can avoid a call to the `exif_transpose` method. opw-2369166 [0] python-pillow/Pillow#4346 [1] python-pillow/Pillow#3973 [2] python-pillow/Pillow#4238 [3] python-pillow/Pillow#4637 [4] python-pillow/Pillow#3980 [5] python-pillow/Pillow#4009 X-original-commit: b83c48d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #3973.
Changes proposed in this pull request: