Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return from ImagingFill early if image has a zero dimension #6842

Merged
merged 2 commits into from Dec 31, 2022

Conversation

radarhere
Copy link
Member

ImagingAllocateArray returns early when the image has zero width or height.

This PR applies that to ImagingFill as well.

@radarhere
Copy link
Member Author

A timeout of 0.1s failed on amazon-2-amd64, so I've increased it to 0.5s.

@radarhere
Copy link
Member Author

The new test started failing on valgrind, and I've even seen it fail once on ubuntu-18.04-bionic-amd64, so I've increased the timeout to 0.75s.

To fix intermittent valgrind problems with this new test, and the existing intermittent failures with test_redos() in test_file_pdf.py, I've pushed a change to skip these tests on valgrind.

@hugovk hugovk merged commit 7b0008b into python-pillow:main Dec 31, 2022
@radarhere radarhere deleted the zero branch December 31, 2022 11:24
radarhere added a commit to radarhere/Pillow that referenced this pull request Jan 1, 2023
mergify bot added a commit that referenced this pull request Jan 1, 2023
@radarhere radarhere mentioned this pull request Sep 1, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants