Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make TIFF strip size configurable #5744

Merged
merged 5 commits into from Oct 14, 2021
Merged

Make TIFF strip size configurable #5744

merged 5 commits into from Oct 14, 2021

Conversation

kmilos
Copy link
Contributor

@kmilos kmilos commented Oct 1, 2021

Fixes #5740

Changes proposed in this pull request:

  • Add a way to override the strip size by redefining PIL.TiffImagePlugin.STRIP_SIZE (in bytes)
  • Do not round up rows_per_strip, requested strip size should not be exceeded

@radarhere radarhere added the TIFF label Oct 1, 2021
@radarhere radarhere mentioned this pull request Oct 8, 2021
Merged
@radarhere
Copy link
Member

I created kmilos#3 to add a test for this.

nulano
nulano reviewed Oct 13, 2021
View reviewed changes
Tests/test_file_libtiff.py Outdated Show resolved Hide resolved
radarhere and others added 2 commits October 14, 2021 08:09
@radarhere @nulano
Ensure reset after test failure
1140f65 
Co-authored-by: Ondrej Baranovič <nulano@nulano.eu>
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
dbb0a41 
for more information, see https://pre-commit.ci
@kmilos
Copy link
Contributor Author

kmilos commented Oct 14, 2021

Thanks for fixing up the PR!

@hugovk hugovk merged commit e04f2ed into python-pillow:master Oct 14, 2021
@hugovk
Copy link
Member

hugovk commented Oct 14, 2021

Thanks all!

@kmilos kmilos deleted the patch-2 branch October 14, 2021 14:16
@radarhere radarhere mentioned this pull request Aug 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@radarhere radarhere radarhere left review comments

@nulano nulano nulano left review comments

Assignees
No one assigned
Labels
TIFF
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Multi-strip usage when encoding group4 TIF breaks use in PDF
4 participants
@kmilos @radarhere @hugovk @nulano