Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed incorrect operator in ImageCms error #6370

Merged
merged 7 commits into from
Jun 19, 2022
Merged

Fixed incorrect operator in ImageCms error #6370

merged 7 commits into from
Jun 19, 2022

Commits on Jun 15, 2022

  1. Fix a potential wrong operator bug

    @LostBenjamin
    LostBenjamin committed Jun 15, 2022
    Configuration menu
    Copy the full SHA
    b47bcc2 View commit details
    Browse the repository at this point in the history

  2. Test ImageCms.profileToProfile with invalid flags

    @hugovk
    hugovk committed Jun 15, 2022
    Configuration menu
    Copy the full SHA
    6c889d1 View commit details
    Browse the repository at this point in the history

  3. Check other exception messages

    @hugovk
    hugovk committed Jun 15, 2022
    Configuration menu
    Copy the full SHA
    983a613 View commit details
    Browse the repository at this point in the history

  4. Use f-string

    @hugovk
    hugovk committed Jun 15, 2022
    Configuration menu
    Copy the full SHA
    959e576 View commit details
    Browse the repository at this point in the history

  5. More generic match text

    @hugovk
    hugovk committed Jun 15, 2022
    Configuration menu
    Copy the full SHA
    6ae6a24 View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2022

  1. Update comment 

    We get "an integer is required (got type NoneType)" with Python 3.7-3.9 on Windows.

We get "'NoneType' object cannot be interpreted as an integer" with Python 3.10 on Windows and all versions on macOS and Ubuntu.
    @hugovk
    hugovk committed Jun 19, 2022
    Configuration menu
    Copy the full SHA
    607f508 View commit details
    Browse the repository at this point in the history

  2. Update comment 

    Co-authored-by: Andrew Murray <3112309+radarhere@users.noreply.github.com>
    @hugovk @radarhere
    hugovk and radarhere committed Jun 19, 2022
    Configuration menu
    Copy the full SHA
    1229110 View commit details
    Browse the repository at this point in the history