Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support saving JPEG comments #6774

Merged
merged 12 commits into from Dec 7, 2022
Merged

Support saving JPEG comments #6774

merged 12 commits into from Dec 7, 2022

Commits on Dec 2, 2022

  1. support round-tripping JPEG comments

    @smason
    smason committed Dec 2, 2022
    Copy the full SHA
    d822d85 View commit details
    Browse the repository at this point in the history

  2. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Dec 2, 2022
    Copy the full SHA
    e9f4858 View commit details
    Browse the repository at this point in the history

  3. Save comments from any image format by default

    @radarhere
    radarhere committed Dec 2, 2022
    Copy the full SHA
    976ad57 View commit details
    Browse the repository at this point in the history

  4. Use _binary instead of struct

    @radarhere
    radarhere committed Dec 2, 2022
    Copy the full SHA
    c1d0a00 View commit details
    Browse the repository at this point in the history

  5. Test that comment is reread

    @radarhere
    radarhere committed Dec 2, 2022
    Copy the full SHA
    525c011 View commit details
    Browse the repository at this point in the history

Commits on Dec 3, 2022

  1. Merge pull request #1 from radarhere/write-jpeg-com 

    Support saving JPEG comments
    @smason
    smason committed Dec 3, 2022
    Copy the full SHA
    e71f7c1 View commit details
    Browse the repository at this point in the history

  2. make sure passing a blank comment removes existing comment

    @smason
    smason committed Dec 3, 2022
    Copy the full SHA
    1ed1a3a View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2022

  1. Use jpeg_write_marker to write comment

    @radarhere
    radarhere committed Dec 5, 2022
    Copy the full SHA
    e50ae85 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #2 from radarhere/write-jpeg-com 

    Use jpeg_write_marker to write comment
    @smason
    smason committed Dec 5, 2022
    Copy the full SHA
    399975f View commit details
    Browse the repository at this point in the history

  3. switch to #z for comment parameter 

    * means `comment=None` can be passed directly
* no need to conditionally run `str.encode()`
* clean up checking of whether a comment is passed
    @smason
    smason committed Dec 5, 2022
    Copy the full SHA
    eddc9bd View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2022

  1. Free comment when returning early

    @radarhere
    radarhere committed Dec 6, 2022
    Copy the full SHA
    1d78008 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #3 from radarhere/write-jpeg-com 

    Free comment when returning early
    @smason
    smason committed Dec 6, 2022
    Copy the full SHA
    6ca08a4 View commit details
    Browse the repository at this point in the history