Get Build Platlib Dir From Build Env #726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks very much for the feedback. All changes adopted. |
When poetry-core run is not run in build environment, build platlib directory now derived from build env via subprocess call, similar to _get_sys_tags()
_get_build_platlib_dir only called if build script Co-authored-by: Randy Döring <30527984+radoering@users.noreply.github.com>
Co-authored-by: Randy Döring <30527984+radoering@users.noreply.github.com>
Co-authored-by: Randy Döring <30527984+radoering@users.noreply.github.com>
radoering
changed the title
radoering
approved these changes
May 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When poetry-core is not run in the build environment, the build platlib directory, in particular the cache_tag string, is now derived from the build environment via a subprocess call, similar to _get_sys_tags(). Previously build platlib was always derived from the poetry-core environment, resulting in a build error if the Python version differed between the poetry-core and build environments.
Resolves: python-poetry/poetry#9344
No new tests added. Changes tested by existing build_with_build_py_only test.
No change to documentation required.