Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix locked information for path, url and VCS dependencies #4202

Merged
merged 1 commit into from
Jun 23, 2021

Conversation

sdispater
Copy link
Member

@sdispater sdispater commented Jun 23, 2021

After #3875 (#3947 for the 1.1 branch), people were starting to see issues where packages would not be installed or would be removed.

This was a bit tricky to track down but the cause was that the locked data for dependencies were not correct which caused packages to be discarded in the resolution process.

This issue has existed for quite some time but was not discovered until now because the fact that all packages were whitelisted meant that they were not retrieved from the lock file.

Note that users will need to update their lock file for the fix to take effect. It's also important to note that lock --no-update will not work and a full relock will be needed.

Pull Request Check List

Resolves: #4051
Resolves: #3956
Resolves: #4111

  • Added tests for changed code.
  • Updated documentation for changed code.

@sdispater sdispater added kind/bug Something isn't working as expected area/solver Related to the dependency resolver area/installer Related to the dependency installer labels Jun 23, 2021
@sdispater sdispater requested a review from a team June 23, 2021 08:27
@sonarcloud
Copy link

sonarcloud bot commented Jun 23, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link

github-actions bot commented Mar 1, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/installer Related to the dependency installer area/solver Related to the dependency resolver kind/bug Something isn't working as expected
Projects
None yet
1 participant