Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: write to stderr in utils.env #6429

Merged
merged 1 commit into from Sep 6, 2022

Commits on Sep 6, 2022

  1. fix: write to stderr in utils.env

    This is a quick fix to avoid polluting stdout unexpectedly when Poetry's
    environment management comes into play.
    
    It's apparent from how much the complexity of this file has grown that
    this needs to be refactored moderately, as well as each major class
    deserving its own source file.
    
    Future work should also include a rethink of how IO objects are passed
    around the codebase, how we reason about verbosity at a function level,
    and how code is re-used -- one command may wish to output to stdout, but
    if that code is reused by another command, the calculus of what is
    command output and what is informative (or even needs to be hidden/shown
    based on verbosity level) changes.
    
    Work on output would likely have to be fairly comprehensive and
    invasive, but things have grown complex enough that a top-down design
    pass is likely the best route.
    
    Regardless, this is a simple change today, and low risk. Resolves python-poetry#6427.
    neersighted committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    5924cfb View commit details
    Browse the repository at this point in the history