Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pip no input #6724

Merged
merged 1 commit into from Oct 7, 2022
Merged

Pip no input #6724

merged 1 commit into from Oct 7, 2022

Conversation

dimbleby
Copy link
Contributor

@dimbleby dimbleby commented Oct 6, 2022

Sometimes pip will ask for user input.

But in the context of poetry: the user never gets to see that request, and so it just looks as though poetry has hung.

I think this may have been what was going on in #6668

Anyway passing --no-input seems sensible and safe.

@radoering radoering added area/installer Related to the dependency installer impact/backport Requires backport to stable branch backport/1.2 labels Oct 6, 2022
@neersighted
Copy link
Member

@radoering I'm personally not sure on backporting this to 1.2 -- I understand pragmatism in getting it out sooner than later in case we can't cut 1.3 this weekend, but also I think we should do --isolated at the same time if we do so.

@neersighted neersighted added kind/enhancement Not a bug or feature, but improves usability or performance impact/changelog Requires a changelog entry labels Oct 6, 2022
@radoering
Copy link
Member

I have no strong feelings about it. I just thought, it's little risk but we can also remove the labels.

Just to be clear, IMO this weekend is no option for 1.3. We should cut 1.3 only some time after 1.2.2. Thus, I'd hope for 1.2.2 this weekend and 1.3 some weeks later.

@neersighted
Copy link
Member

neersighted commented Oct 7, 2022 •
edited

Yeah, I realize now that due to the new lock file format we'll need to try to announce it loudly and give it some soak time.

Regarding a backport, your call, I just think we should also do #6531 at the same time if we do.

@radoering
Copy link
Member

I'm not sure if #6531 is more risk since it's more like a change in behavior. So maybe postpone it to 1.3. Thus, I would pass the ball back to you. 😉

@neersighted neersighted removed impact/backport Requires backport to stable branch backport/1.2 labels Oct 7, 2022
@neersighted neersighted enabled auto-merge (rebase) October 7, 2022 04:39
@neersighted neersighted merged commit 96cdcdb into python-poetry:master Oct 7, 2022
@dimbleby dimbleby deleted the pip-no-input branch October 7, 2022 07:40
@neersighted neersighted added this to the 1.3 milestone Oct 10, 2022
@neersighted neersighted mentioned this pull request Oct 10, 2022
Closed
3 tasks
@coobas coobas mentioned this pull request Nov 4, 2022
Merged
finswimmer pushed a commit that referenced this pull request Nov 11, 2022
@coobas
pip install --no-input everywhere (#6966)
455c0b2 
This is an extension of
#6724. I think `pip install`
invoked by poetry should never ask for user input.

Motivation is that it happened to myself and a number of colleagues many
times that poetry got seemingly stuck while it was just waiting for a
user input because of a private pypi repository that needed
authentication.

I hope this is a valuable contribution to a tool I like a lot and would
like to use more and more :)
moonsikpark added a commit to moonsikpark/poetry that referenced this pull request Nov 15, 2022
@moonsikpark
chore: update mypy >= 0.990
1bb1bba 
update lockfile.

pip install --no-input everywhere (python-poetry#6966)

This is an extension of
python-poetry#6724. I think `pip install`
invoked by poetry should never ask for user input.

Motivation is that it happened to myself and a number of colleagues many
times that poetry got seemingly stuck while it was just waiting for a
user input because of a private pypi repository that needed
authentication.

I hope this is a valuable contribution to a tool I like a lot and would
like to use more and more :)

docs: update Windows cache path to match 1.2

Bump `xattr` version to `0.10.0`. (python-poetry#7005)

Resolves: python-poetry#6928

<!-- This is just a reminder about the most common mistakes. Please make
sure that you tick all *appropriate* boxes. But please read our
[contribution guide](https://python-poetry.org/docs/contributing/) at
least once, it will save you unnecessary review cycles! -->

- [ ] Added **tests** for changed code.
- [ ] Updated **documentation** for changed code.

<!-- If you have *any* questions to *any* of the points above, just
**submit and ask**! This checklist is here to *help* you, not to deter
you from contributing! -->

Bump `xattr` version to `0.10.0`.

This fixes python-poetry#6891, which is not a problem with the user's environment as
suggested by the maintainer of xattr at xattr/xattr#108, but in fact the
problem of the package which was fixed by xattr/xattr#106.

Looking at the [changes in the version
bump](xattr/xattr@v0.9.9...v0.10.0), there
does not seem to be any significant changes other than shabang
xattr/xattr#106.

Co-authored-by: Moonsik Park <moonsik.park@estsoft.com>
Co-authored-by: Bartosz Sokorski <b.sokorski@gmail.com>

tests: add coverage to `poetry install`

update lockfile.

[pre-commit.ci] pre-commit autoupdate

updates:
- [github.com/asottile/pyupgrade: v3.2.0 → v3.2.2](asottile/pyupgrade@v3.2.0...v3.2.2)
- [github.com/hadialqattan/pycln: v2.1.1 → v2.1.2](hadialqattan/pycln@v2.1.1...v2.1.2)
moonsikpark added a commit to moonsikpark/poetry that referenced this pull request Nov 15, 2022
@moonsikpark
chore: update mypy >= 0.990
f74ac1d 
update lockfile.

pip install --no-input everywhere (python-poetry#6966)

This is an extension of
python-poetry#6724. I think `pip install`
invoked by poetry should never ask for user input.

Motivation is that it happened to myself and a number of colleagues many
times that poetry got seemingly stuck while it was just waiting for a
user input because of a private pypi repository that needed
authentication.

I hope this is a valuable contribution to a tool I like a lot and would
like to use more and more :)

docs: update Windows cache path to match 1.2

Bump `xattr` version to `0.10.0`. (python-poetry#7005)

Resolves: python-poetry#6928

<!-- This is just a reminder about the most common mistakes. Please make
sure that you tick all *appropriate* boxes. But please read our
[contribution guide](https://python-poetry.org/docs/contributing/) at
least once, it will save you unnecessary review cycles! -->

- [ ] Added **tests** for changed code.
- [ ] Updated **documentation** for changed code.

<!-- If you have *any* questions to *any* of the points above, just
**submit and ask**! This checklist is here to *help* you, not to deter
you from contributing! -->

Bump `xattr` version to `0.10.0`.

This fixes python-poetry#6891, which is not a problem with the user's environment as
suggested by the maintainer of xattr at xattr/xattr#108, but in fact the
problem of the package which was fixed by xattr/xattr#106.

Looking at the [changes in the version
bump](xattr/xattr@v0.9.9...v0.10.0), there
does not seem to be any significant changes other than shabang
xattr/xattr#106.

Co-authored-by: Moonsik Park <moonsik.park@estsoft.com>
Co-authored-by: Bartosz Sokorski <b.sokorski@gmail.com>

tests: add coverage to `poetry install`

update lockfile.

[pre-commit.ci] pre-commit autoupdate

updates:
- [github.com/asottile/pyupgrade: v3.2.0 → v3.2.2](asottile/pyupgrade@v3.2.0...v3.2.2)
- [github.com/hadialqattan/pycln: v2.1.1 → v2.1.2](hadialqattan/pycln@v2.1.1...v2.1.2)
moonsikpark added a commit to moonsikpark/poetry that referenced this pull request Nov 15, 2022
@moonsikpark
chore: update mypy >= 0.990
87fca65 
update lockfile.

pip install --no-input everywhere (python-poetry#6966)

This is an extension of
python-poetry#6724. I think `pip install`
invoked by poetry should never ask for user input.

Motivation is that it happened to myself and a number of colleagues many
times that poetry got seemingly stuck while it was just waiting for a
user input because of a private pypi repository that needed
authentication.

I hope this is a valuable contribution to a tool I like a lot and would
like to use more and more :)

docs: update Windows cache path to match 1.2

Bump `xattr` version to `0.10.0`. (python-poetry#7005)

Resolves: python-poetry#6928

<!-- This is just a reminder about the most common mistakes. Please make
sure that you tick all *appropriate* boxes. But please read our
[contribution guide](https://python-poetry.org/docs/contributing/) at
least once, it will save you unnecessary review cycles! -->

- [ ] Added **tests** for changed code.
- [ ] Updated **documentation** for changed code.

<!-- If you have *any* questions to *any* of the points above, just
**submit and ask**! This checklist is here to *help* you, not to deter
you from contributing! -->

Bump `xattr` version to `0.10.0`.

This fixes python-poetry#6891, which is not a problem with the user's environment as
suggested by the maintainer of xattr at xattr/xattr#108, but in fact the
problem of the package which was fixed by xattr/xattr#106.

Looking at the [changes in the version
bump](xattr/xattr@v0.9.9...v0.10.0), there
does not seem to be any significant changes other than shabang
xattr/xattr#106.

Co-authored-by: Moonsik Park <moonsik.park@estsoft.com>
Co-authored-by: Bartosz Sokorski <b.sokorski@gmail.com>

tests: add coverage to `poetry install`

update lockfile.

[pre-commit.ci] pre-commit autoupdate

updates:
- [github.com/asottile/pyupgrade: v3.2.0 → v3.2.2](asottile/pyupgrade@v3.2.0...v3.2.2)
- [github.com/hadialqattan/pycln: v2.1.1 → v2.1.2](hadialqattan/pycln@v2.1.1...v2.1.2)

update lockfile.

update lockfile.
@radoering radoering mentioned this pull request Dec 3, 2022
Merged
@neersighted neersighted mentioned this pull request Jan 3, 2023
Closed
3 tasks
@github-actions GitHub Actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@neersighted neersighted neersighted approved these changes

Assignees
No one assigned
Labels
area/installer Related to the dependency installer impact/changelog Requires a changelog entry kind/enhancement Not a bug or feature, but improves usability or performance
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dimbleby @neersighted @radoering