Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle importlib-metadata deprecation #7774

Merged

Conversation

dimbleby
Copy link
Contributor

@dimbleby dimbleby commented Apr 7, 2023

@dimbleby dimbleby force-pushed the importlib-metadata-deprecation branch 2 times, most recently from 3f26265 to 246a65b Compare April 7, 2023 13:38
@dimbleby
Copy link
Contributor Author

dimbleby commented Apr 7, 2023

slightly surprised - in a good way - to see that importlib-metadata MR being merged already. So let's go back to the "use .get() and suppress mypy for now" plan.

@dimbleby dimbleby force-pushed the importlib-metadata-deprecation branch 2 times, most recently from 5fd43c0 to 3a31634 Compare April 7, 2023 17:17
importlib-metadata promises that it will start raising KeyError for
missing values, rather than returning None
@dimbleby dimbleby force-pushed the importlib-metadata-deprecation branch from 3a31634 to 8c9cfaf Compare April 7, 2023 17:47
@radoering radoering merged commit f6e1f93 into python-poetry:master Apr 8, 2023
21 checks passed
@dimbleby dimbleby deleted the importlib-metadata-deprecation branch April 8, 2023 12:35
Copy link

github-actions bot commented Mar 3, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants