Fixes #495 test failing due to zlib not being compiled in some systems

python-rope · Jul 21, 2022 · ea40f51 · ea40f51
1 parent 38bdaa4
commit ea40f51
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 7 deletions.
diff --git a/rope/contrib/autoimport/utils.py b/rope/contrib/autoimport/utils.py
@@ -28,6 +28,9 @@ def get_package_tuple(
         if package_name.endswith(".so"):
             package_name = package_name.split(".")[0]
             package_type = PackageType.COMPILED
+        elif package_name.endswith(".pyd"):
+            package_name = package_name.split(".")[0]
+            package_type = PackageType.COMPILED
         elif package_name.endswith(".py"):
             package_name = package_path.stem
             package_type = PackageType.SINGLE_FILE

diff --git a/ropetest/contrib/autoimport/conftest.py b/ropetest/contrib/autoimport/conftest.py
@@ -52,7 +52,7 @@ def build_path():
 
 
 @pytest.fixture
-def zlib_path():
-    import zlib
+def compiled_lib():
+    import _sqlite3
 
-    yield pathlib.Path(zlib.__file__)
+    yield "_sqlite3", pathlib.Path(_sqlite3.__file__)
diff --git a/ropetest/contrib/autoimport/utilstest.py b/ropetest/contrib/autoimport/utilstest.py
@@ -56,8 +56,8 @@ def test_get_package_tuple_typing(typing_path):
     ) == utils.get_package_tuple(typing_path)
 
 
-@pytest.mark.skipif(platform == "win32", reason="Windows doesn't have compiled modules")
-def test_get_package_tuple_compiled(zlib_path):
+def test_get_package_tuple_compiled(compiled_lib):
+    lib_name, lib_path = compiled_lib
     assert Package(
-        "zlib", Source.STANDARD, zlib_path, PackageType.COMPILED
-    ) == utils.get_package_tuple(zlib_path)
+	lib_name, Source.STANDARD, lib_path, PackageType.COMPILED
+    ) == utils.get_package_tuple(lib_path)