Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: pyflakes nit 4: unused var #613

Merged
merged 4 commits into from Dec 16, 2022
Merged

PR: pyflakes nit 4: unused var #613

merged 4 commits into from Dec 16, 2022

Conversation

edreamleo
Copy link
Contributor

The fourth and last PR in this round of cleanups.

Other pyflakes complaints may disappear later as part of new PRs.

@edreamleo edreamleo changed the title PR: Remove pyflakes complaint re unused var PR: pyflakes nit 4: unused var Dec 16, 2022
lieryan
lieryan reviewed Dec 16, 2022
View reviewed changes
rope/contrib/findit.py Outdated Show resolved Hide resolved
@lieryan lieryan enabled auto-merge (rebase) December 16, 2022 15:23
@lieryan lieryan merged commit da95587 into python-rope:master Dec 16, 2022
@edreamleo edreamleo deleted the ekr-pyflakes-nit4 branch December 16, 2022 15:37
edreamleo
edreamleo commented Dec 17, 2022
View reviewed changes
Copy link
Contributor Author

@edreamleo edreamleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lieryan Thanks for the simplification.

I hesitated to remove the call to get_pymodule because it wasn't an entirely trivial change

@edreamleo edreamleo mentioned this pull request Dec 17, 2022
Closed
5 tasks
@lieryan lieryan added this to the 1.7.0 milestone Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lieryan lieryan lieryan left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@edreamleo @lieryan