-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: Update mypy annotations #617
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lieryan
reviewed
Jan 3, 2023
Fixed at Rev e121c8f. |
@lieryan I am going to close this PR. I'll use ekr-fork-rope2 to work on the Theory of Operation without bothering you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR suggests suppressing and updating annotations in stages:
# type:ignore
comments to eliminate all mypy complaints.pyfunction
,pymodule
,pyobject
andscope
.# type:ignore
comments.# type:ignore
comments for optional import statements.type_hinting/evaluate.py
,prefs.py
andversioning.py
.Any
annotations.rope.base
.Valid mypy complaints
The following complaints suggest real errors in Rope:
MoveGlobal.get_changes
: "Resource" has no attribute "has_child"/ "get_child"._GlobalUnboundNameFinder.__init__
: "PyObject" has no attribute "get_scope".AutoImport._get_python_folders
:error: Incompatible types in assignment
(expression has type "filter[Path]", variable has type "map[Path]")