-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New AutoImport implementation (early-merge of @bageljrkhanofemus's changes) #467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lieryan
changed the title
New AutoImport implementation (early-merge)
New AutoImport implementation (early-merge of @bageljrkhanofemus's changes)
Apr 28, 2022
…ntations in the documentation
lieryan
force-pushed
the
bageljrkhanofemus-464-autoimport-sqlite3
branch
from
April 28, 2022 03:54
880aee6
to
78183da
Compare
lieryan
force-pushed
the
bageljrkhanofemus-464-autoimport-sqlite3
branch
from
April 28, 2022 04:31
f5989c5
to
4c3dbca
Compare
…64-autoimport-sqlite3
Replace the test to use typing.Text instead
lieryan
force-pushed
the
bageljrkhanofemus-464-autoimport-sqlite3
branch
from
April 28, 2022 04:46
0154f56
to
7fc0c3d
Compare
lieryan
added
the
api-change
New features that requires changes to editor integrations to make use of
label
Jun 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is basically @bageljrkhanofemus Pull Request #464 of reworking AutoImport to use sqlite3-based cache and speeding up module discovery.
I'm recreating the pull request here for early merging @bageljrkhanofemus changes, while keeping the existing of pickle-based AutoImport cache implementation as the default AutoImport implementation for now to ease transitions for existing editor integrations.
The pickle-based implementation is now deprecated and will be removed in the future.
Further discussions of this PR should be made in #464.