Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Add type annotations for rope.contrib.generate.create_generate() #641

Merged
merged 9 commits into from
Jan 5, 2023
Merged

PR: Add type annotations for rope.contrib.generate.create_generate() #641

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
8fc5abb
Improve docstring for create_generate
edreamleo Jan 4, 2023
39a26e2
Fully annotate create_generate
edreamleo Jan 4, 2023
9b1fa56
Back out of Literal annotation
edreamleo Jan 4, 2023
7d220ea
Merge branch 'master' into ekr-ropemode-docstring
edreamleo Jan 4, 2023
af8f5c0
Merge branch 'master' into ekr-ropemode-docstring
edreamleo Jan 4, 2023
d85914b
Fix recent problems w/ annotations. Punt on the return type for now
edreamleo Jan 4, 2023
c9929a0
Merge branch 'ekr-ropemode-docstring' of https://github.com/edreamleo…
edreamleo Jan 4, 2023
4242e94
Merge branch 'master' into ekr-ropemode-docstring
lieryan Jan 4, 2023
2fc4bb8
Annotate rope.contrib.generate.create_generate(kind) with Literal
lieryan Jan 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 3 additions & 2 deletions rope/contrib/generate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,9 @@
def create_generate(kind, project, resource, offset, goal_resource=None):
"""A factory for creating `Generate` objects

`kind` can be 'variable', 'function', 'class', 'module' or
'package'.
`kind`: 'variable', 'function', 'class', 'module' or 'package'.
edreamleo marked this conversation as resolved.
Show resolved Hide resolved

Used in https://github.com/python-rope/ropemode but not in Rope itself.

"""
d = {
Expand Down