Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Removed unused __init__() methods #655

Merged
merged 6 commits into from
Feb 6, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# **Upcoming release**

- #650 Install pre-commit hooks on rope repository (@lieryan)
- #655 Remove unused __init__() methods (@edreamleo, @lieryan)


# Release 1.7.0
Expand Down
6 changes: 1 addition & 5 deletions rope/base/pyobjectsdef.py
Original file line number Diff line number Diff line change
Expand Up @@ -583,14 +583,10 @@ def _get_pyobject(self, node):


class _GlobalVisitor(_ScopeVisitor):
def __init__(self, pycore, owner_object):
super().__init__(pycore, owner_object)
pass


class _ClassVisitor(_ScopeVisitor):
def __init__(self, pycore, owner_object):
super().__init__(pycore, owner_object)

def _FunctionDef(self, node):
_ScopeVisitor._FunctionDef(self, node)
if len(node.args.args) > 0:
Expand Down
3 changes: 0 additions & 3 deletions rope/base/resources.py
Original file line number Diff line number Diff line change
Expand Up @@ -159,9 +159,6 @@ def create(self):
class Folder(Resource):
"""Represents a folder"""

def __init__(self, project, name):
super().__init__(project, name)

def is_folder(self):
return True

Expand Down
6 changes: 0 additions & 6 deletions rope/base/taskhandle.py
Original file line number Diff line number Diff line change
Expand Up @@ -164,9 +164,6 @@ def increment(self):


class NullTaskHandle(BaseTaskHandle):
def __init__(self):
pass

def is_stopped(self):
return False

Expand All @@ -188,9 +185,6 @@ def current_jobset(self) -> None:


class NullJobSet(BaseJobSet):
def __init__(self, *args):
pass

def started_job(self, name):
pass

Expand Down