Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Fix/suppress all mypy complaints (based on master) #674

Merged
merged 8 commits into from
Mar 2, 2023
Merged

PR: Fix/suppress all mypy complaints (based on master) #674

merged 8 commits into from
Mar 2, 2023

Commits on Feb 25, 2023

  1. Add minimal mypy annotations to eliminate all complaints. Add two nec… 

    …essary base-class methods
    @edreamleo
    edreamleo committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    0ab5815 View commit details
    Browse the repository at this point in the history

  2. Explain the suppression in rope.base.ast

    @edreamleo
    edreamleo committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    df8224a View commit details
    Browse the repository at this point in the history

  3. Remove unnecessary 'Any' annotation to reduce the diffs

    @edreamleo
    edreamleo committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    bcabc86 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into ekr-annotations

    @edreamleo
    edreamleo committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    f1310de View commit details
    Browse the repository at this point in the history

  5. Improve a comment

    @edreamleo
    edreamleo committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    845786b View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2023

  1. Inline PyObj 

    Seems like an unnecessary mental indirection to alias this when it's
just used twice in the same type definition. Maybe if there's more of
this pair, then it might be worth it to define this alias.
    @lieryan
    lieryan committed Mar 2, 2023
    Configuration menu
    Copy the full SHA
    7af5370 View commit details
    Browse the repository at this point in the history

  2. Add a comment on resolve_type()

    @lieryan
    lieryan committed Mar 2, 2023
    Configuration menu
    Copy the full SHA
    bcc5cf8 View commit details
    Browse the repository at this point in the history

  3. Update CHANGELOG.md

    @lieryan
    lieryan committed Mar 2, 2023
    Configuration menu
    Copy the full SHA
    0d13f87 View commit details
    Browse the repository at this point in the history