Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix changelog generation in tag-mode (#171) #486

Conversation

betaboon
Copy link
Contributor

@betaboon betaboon commented Aug 5, 2022

resolves #171

i tested this locally.

the whole-testsuite seems to still pass.

i have no clue how to test this with the given test-infrastructure tho.

suggestions and contributions to cover this with tests are highly welcome

semantic_release/vcs_helpers.py Outdated Show resolved Hide resolved
semantic_release/vcs_helpers.py Outdated Show resolved Hide resolved
@danth
Copy link
Member

danth commented Aug 5, 2022

The commitlint failure is because your commit message starts with a capital.

@betaboon betaboon force-pushed the fix/171-changelog-generation-tag-mode branch from 6997a66 to 85eae44 Compare August 5, 2022 17:28
@betaboon
Copy link
Contributor Author

betaboon commented Aug 5, 2022

The commitlint failure is because your commit message starts with a capital.

That's funny. i was looking at the recent history on the repo to comply to the commit-messages.
The recent commits from @relekang seem to also break that commit-message rule :P

@danth
Copy link
Member

danth commented Aug 5, 2022

We capitalise everything anyway when it goes into the changelog:

https://github.com/relekang/python-semantic-release/blob/5f28b835b0dbaaeaf2d80c6caaac3d66d4f7d0b0/semantic_release/history/logs.py#L126-L128

The linter is probably a bit too strict.

Anyway, these changes look good. Have you tested this in commit-mode too?

@betaboon
Copy link
Contributor Author

betaboon commented Aug 5, 2022

Anyway, these changes look good. Have you tested this in commit-mode too?

i tested this locally with tag_only + the current test-suite.
so no: didnt manually with commit-mode

@codejedi365
Copy link
Contributor

I believe this PR might also solve #362 ?

@danth
Copy link
Member

danth commented Aug 23, 2022

@betaboon Please can you rebase this to fix the conflicts. I will merge once that is done.

@betaboon
Copy link
Contributor Author

I'm not close to a computer for the next couple of weeks.
So either you wait or do it yourself 😉

@bernardcooke53 bernardcooke53 mentioned this pull request Aug 29, 2022
@ihowell-phaidra
Copy link

+1 to this branch. I am also being impacted by #362, which this solves.

@betaboon
Copy link
Contributor Author

I just tried rebasing this branch, but there are some conflicts that I'm unsure about, that are the result of #488

@betaboon betaboon force-pushed the fix/171-changelog-generation-tag-mode branch from 85eae44 to b8a56a8 Compare October 18, 2022 13:42
@relekang relekang merged commit 482a62e into python-semantic-release:master Oct 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changelog generation broken in tag mode
5 participants