Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct spelling mistakes #504

Merged
merged 1 commit into from Oct 1, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions semantic_release/repository.py
Expand Up @@ -123,7 +123,7 @@ def _handle_repository_config(self) -> None:
def _create_twine_settings(self, addon_kwargs: Dict[str, Any]) -> TwineSettings:
"""
Gather all parameters that had a value set during instantiation and
pass them to Twine which then validates and laods the config.
pass them to Twine which then validates and loads the config.
"""
params = {name: val for name, val in dataclass_asdict(self).items() if val}
settings = TwineSettings(**params, **addon_kwargs)
Expand All @@ -148,7 +148,7 @@ def upload(
:raises ImproperConfigurationError:
The upload failed due to a configuration error.

:returns True if successfull, False otherwise.
:returns True if successful, False otherwise.
"""
addon_kwargs = {
"non_interactive": True,
Expand Down
2 changes: 1 addition & 1 deletion tests/test_vcs_helpers.py
Expand Up @@ -539,7 +539,7 @@ def test_update_changelog_empty_file(mock_git, mocker):
def test_update_changelog_file_missing_placeholder(mock_git, mocker):
mocker.patch("semantic_release.vcs_helpers.Path.exists", return_value=True)
mocked_read_text = mocker.patch(
"semantic_release.vcs_helpers.Path.read_text", return_value="# Uknown header"
"semantic_release.vcs_helpers.Path.read_text", return_value="# Unknown header"
)
mocked_write_text = mocker.patch("semantic_release.vcs_helpers.Path.write_text")

Expand Down