Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: optimize & improve maintainability of GitHub Action definition #914

Merged
merged 12 commits into from May 6, 2024

Conversation

codejedi365
Copy link
Contributor

@codejedi365 codejedi365 commented May 5, 2024

Purpose

Optimize the Docker build and improve maintainability of the Docker GitHub Action

Rationale

In order to improve maintainability, I removed the additional defaults of the action and rely on the internal configuration defaults of the package instead.

When using Debian Bullseye, it did not have a git version available
that supported SSH key signing. SSH key signing was integrated in
git version 2.34 and the highest version for Bullseye was 2.30. Through
the backports repository, a version greater than 2.34 was made available
but now bumping to Debian Bookworm, the available version is 2.39 in the
base OS repository so no backports configuration required.
Updates the base container that runs the GitHub Action environment to
python3.12 which enables users to specify and run build scripts that
are python3.12 specific as python3.12 is now the latest stable version
of python available and we were only providing `3.10`.

Resolves: python-semantic-release#801
@codejedi365 codejedi365 added this to the Improve GitHub Actions milestone May 5, 2024
@codejedi365 codejedi365 self-assigned this May 5, 2024
@codejedi365 codejedi365 merged commit 85e27b7 into python-semantic-release:master May 6, 2024
7 checks passed
@codejedi365 codejedi365 deleted the refactor/gha branch May 6, 2024 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant