Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unified docstrings #3292

Merged
merged 6 commits into from
Oct 14, 2022
Merged

Unified docstrings #3292

merged 6 commits into from
Oct 14, 2022

Conversation

penguinpee
Copy link
Contributor

@penguinpee
Unified docstrings
a263163 
- copied mostly from args to attributes
- fixed language
- fixed and improved formatting
- contribution to python-telegram-bot#3109
harshil21
harshil21 requested changes Oct 13, 2022
View reviewed changes
Copy link
Member

@harshil21 harshil21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Most changes are not needed and needs to be reverted, see comments below

telegram/_webappdata.py Outdated Show resolved Hide resolved
telegram/_webappdata.py Outdated Show resolved Hide resolved
telegram/_webappinfo.py Outdated Show resolved Hide resolved
telegram/_webappinfo.py Outdated Show resolved Hide resolved
telegram/_webhookinfo.py Outdated Show resolved Hide resolved
telegram/_webhookinfo.py Outdated Show resolved Hide resolved
telegram/_webhookinfo.py Outdated Show resolved Hide resolved
Sandro and others added 5 commits October 13, 2022 23:01
@harshil21
Update telegram/_webhookinfo.py
5c5a402 
Co-authored-by: Harshil <37377066+harshil21@users.noreply.github.com>
@harshil21
Update telegram/_webhookinfo.py
f7d2161 
Co-authored-by: Harshil <37377066+harshil21@users.noreply.github.com>
@penguinpee
Revrted formatting and spelling
d61ef22
@harshil21
Update telegram/_webhookinfo.py
cac41d2 
Co-authored-by: Harshil <37377066+harshil21@users.noreply.github.com>
@penguinpee
Removed word "attribute" as requested
7225e9c
harshil21
harshil21 approved these changes Oct 14, 2022
View reviewed changes
Copy link
Member

@harshil21 harshil21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harshil21 harshil21 added documentation hacktoberfest-accepted Label PRs with this so that Hacktoberfest counts them as valid labels Oct 14, 2022
@harshil21 harshil21 added this to the v20.0a5 milestone Oct 14, 2022
@harshil21 harshil21 merged commit cba6107 into python-telegram-bot:doc-fixes Oct 14, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Oct 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@harshil21 harshil21 harshil21 approved these changes

Assignees
No one assigned
Labels
documentation hacktoberfest-accepted Label PRs with this so that Hacktoberfest counts them as valid
Projects
None yet
Milestone
v20.0a5
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@penguinpee @harshil21