Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unify args and attributes docstrings in Chat class #3303

Merged
merged 2 commits into from
Oct 24, 2022
Merged

unify args and attributes docstrings in Chat class #3303

merged 2 commits into from
Oct 24, 2022

Conversation

HatimZ
Copy link
Contributor

@HatimZ HatimZ commented Oct 22, 2022

Refer to #3109, Chat class arguments docstrings and attributes docstrings are unified.

Checklist for PRs

  • Added .. versionadded:: version, .. versionchanged:: version or .. deprecated:: version to the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)
  • Created new or adapted existing unit tests
  • Documented code changes according to the CSI standard
  • Added myself alphabetically to AUTHORS.rst (optional)
  • Added new classes & modules to the docs and all suitable __all__ s

@Bibo-Joshi Bibo-Joshi changed the base branch from master to doc-fixes October 23, 2022 13:00
@Bibo-Joshi
Copy link
Member

Hi. Thanks for the PR! The changes themself look good, but unfortunately, there are some trailing whitespaces. See the pre-commit output for details. Please also check out the contribution guide for details on how to set up the pre-commit hooks locally.

@HatimZ
Copy link
Contributor Author

HatimZ commented Oct 23, 2022

@Bibo-Joshi Hi . I have removed the trailing whitespaces. I hope its good now. Thanks!

@Bibo-Joshi Bibo-Joshi merged commit c3e336f into python-telegram-bot:doc-fixes Oct 24, 2022
@Bibo-Joshi
Copy link
Member

Thank you for the contribution! :)

@Bibo-Joshi Bibo-Joshi mentioned this pull request Oct 24, 2022
11 tasks
@harshil21 harshil21 added documentation hacktoberfest-accepted Label PRs with this so that Hacktoberfest counts them as valid labels Oct 26, 2022
@harshil21 harshil21 added this to the v20.0a5 milestone Oct 26, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Nov 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation hacktoberfest-accepted Label PRs with this so that Hacktoberfest counts them as valid
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants