Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support alternatives to trio.run #105

Merged
merged 36 commits into from
Oct 11, 2020

Conversation

altendky
Copy link
Member

@altendky altendky commented Aug 27, 2020

Draft for:

  • Generally finish it up and get rid of all the 1/0 etc
  • Documentation
  • Don't use real QTrio for testing
    • QTrio is excessively onerous when it comes to dependencies and setup for testing
      • PySide2/PyQt5, xvfb, system library dependencies, etc
    • Maybe just create a class with a .run() to set a flag the test can check and otherwise pass on to trio.run()
  • Move trio_test() here
  • Check docstrings
    • Oh, that's why I didn't write any. There weren't any before...
  • Resolution of the multiple-third-party-runs-selected topic at Support alternatives to trio.run #105 (comment).
    • Just use the closest explicit specification

Relates to:

@codecov
Copy link

codecov bot commented Aug 27, 2020

Codecov Report

Merging #105 into master will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #105   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           18        18           
  Lines          490       578   +88     
  Branches        41        50    +9     
=========================================
+ Hits           490       578   +88     
Impacted Files Coverage Δ
pytest_trio/_tests/helpers.py 100.00% <100.00%> (ø)
pytest_trio/_tests/test_fixture_mistakes.py 100.00% <100.00%> (ø)
pytest_trio/_tests/test_trio_mode.py 100.00% <100.00%> (ø)
pytest_trio/plugin.py 100.00% <100.00%> (ø)

@altendky altendky marked this pull request as ready for review August 29, 2020 23:04
pytest_trio/_tests/test_trio_mode.py Show resolved Hide resolved
pytest_trio/_tests/test_trio_mode.py Outdated Show resolved Hide resolved
pytest_trio/plugin.py Outdated Show resolved Hide resolved
pytest_trio/plugin.py Outdated Show resolved Hide resolved
@altendky altendky marked this pull request as draft October 2, 2020 15:41
Copy link
Member Author

@altendky altendky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the help @oremanj.

pytest_trio/_tests/test_trio_mode.py Show resolved Hide resolved
pytest_trio/plugin.py Outdated Show resolved Hide resolved
pytest_trio/plugin.py Outdated Show resolved Hide resolved
pytest_trio/_tests/test_trio_mode.py Outdated Show resolved Hide resolved
@altendky altendky marked this pull request as ready for review October 2, 2020 21:48
pytest_trio/plugin.py Outdated Show resolved Hide resolved
@oremanj
Copy link
Member

oremanj commented Oct 11, 2020

Feel free to hit the merge button when you're happy with this -- sorry for the delay in reviewing, and thanks for your contribution!

@altendky altendky merged commit 7f5c034 into python-trio:master Oct 11, 2020
@altendky altendky deleted the configurable_trio_run branch October 11, 2020 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants