Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update python_requires to >= 3.6 #98

Merged
merged 2 commits into from
Aug 22, 2020

Conversation

altendky
Copy link
Member

Trio >= 0.15.0 is required and that in turn requires Python >= 3.6
@njsmith
Copy link
Member

njsmith commented Aug 22, 2020

Oh, and now CI is broken because of pytest changes (I guess). Fantastic...

@njsmith
Copy link
Member

njsmith commented Aug 22, 2020

Too bad we don't have dependabot on this repo, would have caught it much earlier when pytest made the release that broke things...

@altendky
Copy link
Member Author

Yeah, I was pulling up master to explore.

@altendky
Copy link
Member Author

And yup, it comes back to me anyways... based on issues in pytest-twisted no less.

pytest-dev/pytest#6505
https://github.com/pytest-dev/pytest/pull/7364/files

Testdir.run().parseoutcomes() now always returns the parsed nouns in plural form as of pytest 6.0. Since this is just the tests for pytest-trio itself, rather than the use of pytest-trio by others, I'll just update the tests and require >=6.0 in test-requirements.txt. New PR incoming.

Side note, since we don't pin the deps wouldn't just a nightly build would cut it for catching stuff like this instead of needing dependabot?

@njsmith
Copy link
Member

njsmith commented Aug 22, 2020

Side note, since we don't pin the deps wouldn't just a nightly build would cut it for catching stuff like this instead of needing dependabot?

It could, but pinning + dependabot is better, because when something goes wrong then you end up with a failed PR that you can investigate and resolve at your leisure. Without pinning, things just catch on fire and you find out after the fact when they're already burning.

(Also, I'm not sure how you'd set up useful alerting for nightly builds.)

@codecov
Copy link

codecov bot commented Aug 22, 2020

Codecov Report

Merging #98 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #98   +/-   ##
=======================================
  Coverage   99.79%   99.79%           
=======================================
  Files          18       18           
  Lines         490      490           
  Branches       41       41           
=======================================
  Hits          489      489           
  Misses          1        1           

@njsmith njsmith merged commit 8599a29 into python-trio:master Aug 22, 2020
@altendky altendky deleted the python_requires_3.6 branch August 22, 2020 23:44
@altendky
Copy link
Member Author

Oh sure, as far as alerting I just get an email... as the owner? I don't know. I just meant from the point of not having pinning. And pinning is hard what with no tooling for handling multiple platforms. At least I'm not familiar with anything yet other than my boots/romp combo but... meh.

@njsmith
Copy link
Member

njsmith commented Aug 23, 2020 via email

@pquentin pquentin mentioned this pull request Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants